Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swizzle version banner #1581

Merged
merged 15 commits into from
May 31, 2024
Merged

Swizzle version banner #1581

merged 15 commits into from
May 31, 2024

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

This is basically a rebase of #1093. I didn't add the deprecated banner tho. We can still add it if we see the need for it

Links to any relevant issues

Fixes #1576. (hopefully :trollface: )

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron mentioned this pull request May 28, 2024
Merged
4 tasks
@Dr-Electron Dr-Electron marked this pull request as ready for review May 28, 2024 21:50
@Dr-Electron
Copy link
Collaborator Author

Seems to work. Tested in #1567.

Maybe instead of adding a deprecated banner like we did in the past, what about adding a staging banner?
It could say something like

This is an upcoming version currently deployed on our staging Network Shimmer, for up-to-date …

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: bb61182

✅ Preview: https://iota-wiki-nuummuizk-iota1.vercel.app

jlvandenhout
jlvandenhout reviewed May 29, 2024
View reviewed changes
src/theme/DocVersionBanner/index.tsx Outdated Show resolved Hide resolved
src/utils/pluginConfigGenerators.js Outdated Show resolved Hide resolved
lucas-tortora
lucas-tortora approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@lucas-tortora lucas-tortora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add to Jeroen's review

src/plugins/docs/index.js Show resolved Hide resolved
@lucas-tortora
Copy link
Collaborator

Seems to work. Tested in #1567.

Maybe instead of adding a deprecated banner like we did in the past, what about adding a staging banner? It could say something like

This is an upcoming version currently deployed on our staging Network Shimmer, for up-to-date …

If it's no trouble, I see no reason why not. Though I wouldn't spend too much time on this at the moment.

@Dr-Electron @jlvandenhout
Apply suggestions from code review
c405e55 
Co-authored-by: Jeroen van den Hout <[email protected]>
@Dr-Electron Dr-Electron requested a review from jlvandenhout May 29, 2024 21:26
@Dr-Electron
Copy link
Collaborator Author

Seems to work. Tested in #1567.
Maybe instead of adding a deprecated banner like we did in the past, what about adding a staging banner? It could say something like

This is an upcoming version currently deployed on our staging Network Shimmer, for up-to-date …

If it's no trouble, I see no reason why not. Though I wouldn't spend too much time on this at the moment.

It is like 2min of work ;)
Can you suggest some text for it?

@lucas-tortora
Copy link
Collaborator

Seems to work. Tested in #1567.
Maybe instead of adding a deprecated banner like we did in the past, what about adding a staging banner? It could say something like

This is an upcoming version currently deployed on our staging Network Shimmer, for up-to-date …

If it's no trouble, I see no reason why not. Though I wouldn't spend too much time on this at the moment.

It is like 2min of work ;) Can you suggest some text for it?

The current documentation is only applicable to the Shimmer staging network. The described features and functionalities are under testing and may differ from the IOTA network.

@Dr-Electron Dr-Electron merged commit a5ac39a into main May 31, 2024
9 checks passed
@Dr-Electron Dr-Electron deleted the feat/swizzle-new-version-banner branch May 31, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@jlvandenhout jlvandenhout jlvandenhout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix version banners
3 participants
@Dr-Electron @lucas-tortora @jlvandenhout